Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing changelog for v5.3.3 #15286

Merged
merged 1 commit into from Sep 7, 2023
Merged

Finalizing changelog for v5.3.3 #15286

merged 1 commit into from Sep 7, 2023

Conversation

astrofrog
Copy link
Member

No description provided.

@astrofrog astrofrog added Release skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports backport-main on-merge: backport to main labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@astrofrog astrofrog merged commit 6258f07 into astropy:v5.3.x Sep 7, 2023
38 of 55 checks passed
@pllim pllim added this to the v5.3.3 milestone Sep 7, 2023
@pllim
Copy link
Member

pllim commented Sep 7, 2023

@meeseeksdev backport to main

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 7, 2023
Merged
@pllim
Copy link
Member

pllim commented Sep 7, 2023

p.s. Not sure why the backport-main label does not work. Maybe the labeling is never set up to support forward port. At least comment still triggers it.

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 7, 2023
@astrofrog @meeseeksmachine
Backport PR astropy#15286: Finalizing changelog for v5.3.3
ad3ce6f
pllim added a commit that referenced this pull request Sep 7, 2023
@pllim
Merge pull request #15287 from meeseeksmachine/auto-backport-of-pr-15…
bc0be28 
…286-on-main

Backport PR #15286 on branch main (Finalizing changelog for v5.3.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-main on-merge: backport to main cosmology modeling Release skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks units
Projects
Cosmology, the Expansion
Status: Done
Milestone
v5.3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astrofrog @pllim