Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wheel for PEP 517 fallback builds #2313

Closed
henryiii opened this issue Mar 9, 2024 · 2 comments · Fixed by #2341
Closed

Remove wheel for PEP 517 fallback builds #2313

henryiii opened this issue Mar 9, 2024 · 2 comments · Fixed by #2341
Assignees
Labels
enhancement New feature or request

Comments

@henryiii
Copy link
Contributor

henryiii commented Mar 9, 2024

Setuptools declares wheel as a wheel build dependency for PEP 517 builds already via a build hook. Both pip 24 (pypa/pip#12449) and build 1.1 (pypa/build#716) have removed wheel from the default PEP 517 fallback environment. I think uv should do the same.

There are a small collection of packages that import wheel inside setup.py directly, which is discouraged by wheel (as there's no official pubic API), and these packages should either declare wheel explicitly as a dependency in pyproject.toml, protect the import, or use setuptool's functionality to get a build class without importing it.

@charliermarsh charliermarsh added the enhancement New feature or request label Mar 9, 2024
@charliermarsh
Copy link
Member

Any idea if there are known packages that won't build under this?

@henryiii
Copy link
Contributor Author

They also won't work with pip or build. :) The most recent issue was one with pyodide pyodide/pyodide#4593 - the user forgot to copy the pyproject.toml into the docker container when building. :) Another: pypa/build#750. I think pip took the brunt of this, though, as pip 24 came out before build 1.1, and people using build tend to be more likely to have pyproject.tomls, etc., so looking around in pip's issue tracker might be helpful.

@charliermarsh charliermarsh self-assigned this Mar 10, 2024
charliermarsh added a commit that referenced this issue Mar 10, 2024
## Summary

This matches the latest `pip` and `build` releases. See:
#2313.

Closes #2313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants