From b7d0c01234d1fbbd8985c2889b292563169646b7 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Thu, 21 Mar 2024 13:23:55 -0400 Subject: [PATCH] Rename list-reassign-reversed to list-reverse-copy --- .../ruff_linter/src/checkers/ast/analyze/statement.rs | 2 +- crates/ruff_linter/src/codes.rs | 2 +- crates/ruff_linter/src/rules/refurb/mod.rs | 2 +- .../{list_assign_reversed.rs => list_reverse_copy.rs} | 10 +++++----- crates/ruff_linter/src/rules/refurb/rules/mod.rs | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) rename crates/ruff_linter/src/rules/refurb/rules/{list_assign_reversed.rs => list_reverse_copy.rs} (95%) diff --git a/crates/ruff_linter/src/checkers/ast/analyze/statement.rs b/crates/ruff_linter/src/checkers/ast/analyze/statement.rs index b3502815fd304..a5b7cc2cd8972 100644 --- a/crates/ruff_linter/src/checkers/ast/analyze/statement.rs +++ b/crates/ruff_linter/src/checkers/ast/analyze/statement.rs @@ -1503,7 +1503,7 @@ pub(crate) fn statement(stmt: &Stmt, checker: &mut Checker) { } } } - if checker.enabled(Rule::ListAssignReversed) { + if checker.enabled(Rule::ListReverseCopy) { refurb::rules::list_assign_reversed(checker, assign); } } diff --git a/crates/ruff_linter/src/codes.rs b/crates/ruff_linter/src/codes.rs index 026618259e135..f4b0a97b29b0e 100644 --- a/crates/ruff_linter/src/codes.rs +++ b/crates/ruff_linter/src/codes.rs @@ -1056,7 +1056,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> { (Refurb, "177") => (RuleGroup::Preview, rules::refurb::rules::ImplicitCwd), (Refurb, "180") => (RuleGroup::Preview, rules::refurb::rules::MetaClassABCMeta), (Refurb, "181") => (RuleGroup::Preview, rules::refurb::rules::HashlibDigestHex), - (Refurb, "187") => (RuleGroup::Preview, rules::refurb::rules::ListAssignReversed), + (Refurb, "187") => (RuleGroup::Preview, rules::refurb::rules::ListReverseCopy), // flake8-logging (Flake8Logging, "001") => (RuleGroup::Stable, rules::flake8_logging::rules::DirectLoggerInstantiation), diff --git a/crates/ruff_linter/src/rules/refurb/mod.rs b/crates/ruff_linter/src/rules/refurb/mod.rs index 5a8c6254fbf95..91af7e47d2060 100644 --- a/crates/ruff_linter/src/rules/refurb/mod.rs +++ b/crates/ruff_linter/src/rules/refurb/mod.rs @@ -35,7 +35,7 @@ mod tests { #[test_case(Rule::RedundantLogBase, Path::new("FURB163.py"))] #[test_case(Rule::MetaClassABCMeta, Path::new("FURB180.py"))] #[test_case(Rule::HashlibDigestHex, Path::new("FURB181.py"))] - #[test_case(Rule::ListAssignReversed, Path::new("FURB187.py"))] + #[test_case(Rule::ListReverseCopy, Path::new("FURB187.py"))] fn rules(rule_code: Rule, path: &Path) -> Result<()> { let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy()); let diagnostics = test_path( diff --git a/crates/ruff_linter/src/rules/refurb/rules/list_assign_reversed.rs b/crates/ruff_linter/src/rules/refurb/rules/list_reverse_copy.rs similarity index 95% rename from crates/ruff_linter/src/rules/refurb/rules/list_assign_reversed.rs rename to crates/ruff_linter/src/rules/refurb/rules/list_reverse_copy.rs index dc9e853acf561..7a6c8224821fd 100644 --- a/crates/ruff_linter/src/rules/refurb/rules/list_assign_reversed.rs +++ b/crates/ruff_linter/src/rules/refurb/rules/list_reverse_copy.rs @@ -39,19 +39,19 @@ use crate::checkers::ast::Checker; /// ## References /// - [Python documentation: More on Lists](https://docs.python.org/3/tutorial/datastructures.html#more-on-lists) #[violation] -pub struct ListAssignReversed { +pub struct ListReverseCopy { name: String, } -impl AlwaysFixableViolation for ListAssignReversed { +impl AlwaysFixableViolation for ListReverseCopy { #[derive_message_formats] fn message(&self) -> String { - let ListAssignReversed { name } = self; + let ListReverseCopy { name } = self; format!("Use of assignment of `reversed` on list `{name}`") } fn fix_title(&self) -> String { - let ListAssignReversed { name } = self; + let ListReverseCopy { name } = self; format!("Replace with `{name}.reverse()`") } } @@ -83,7 +83,7 @@ pub(crate) fn list_assign_reversed(checker: &mut Checker, assign: &StmtAssign) { checker.diagnostics.push( Diagnostic::new( - ListAssignReversed { + ListReverseCopy { name: target_expr.id.to_string(), }, assign.range(), diff --git a/crates/ruff_linter/src/rules/refurb/rules/mod.rs b/crates/ruff_linter/src/rules/refurb/rules/mod.rs index 1cef073366127..97bc141fe0d46 100644 --- a/crates/ruff_linter/src/rules/refurb/rules/mod.rs +++ b/crates/ruff_linter/src/rules/refurb/rules/mod.rs @@ -5,7 +5,7 @@ pub(crate) use hashlib_digest_hex::*; pub(crate) use if_expr_min_max::*; pub(crate) use implicit_cwd::*; pub(crate) use isinstance_type_none::*; -pub(crate) use list_assign_reversed::*; +pub(crate) use list_reverse_copy::*; pub(crate) use math_constant::*; pub(crate) use metaclass_abcmeta::*; pub(crate) use print_empty_string::*; @@ -28,7 +28,7 @@ mod hashlib_digest_hex; mod if_expr_min_max; mod implicit_cwd; mod isinstance_type_none; -mod list_assign_reversed; +mod list_reverse_copy; mod math_constant; mod metaclass_abcmeta; mod print_empty_string;