Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect generic Protocol in ellipsis removal #9841

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Closes #9840.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 5, 2024
@charliermarsh charliermarsh marked this pull request as ready for review February 5, 2024 18:52
@Julian
Copy link

Julian commented Feb 5, 2024

I don't know what map_subscript does (but if you don't respond before I look :D) -- I'd double check this also works the right way with "new" generics syntax -- i.e. class Foo[T](Protocol)? Probably that worked even before, but just mentioning it.

EDIT: Yeah that looks like it works even on the current release!

Thanks again for the quick fix!

Copy link
Contributor

github-actions bot commented Feb 5, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error)

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh
Copy link
Member Author

👍 That should already work, but I'll add a test for it too!

@charliermarsh charliermarsh enabled auto-merge (squash) February 5, 2024 19:29
@charliermarsh charliermarsh merged commit 041ce1e into main Feb 5, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/t branch February 5, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruff (via PIE790) incorrectly removes ellipses from Protocols with generics
2 participants