Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid syntax error via importing trio.lowlevel #8730

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Avoid syntax error via importing trio.lowlevel #8730

merged 1 commit into from
Nov 17, 2023

Conversation

charliermarsh
Copy link
Member

We ended up with a syntax error here via from trio import lowlevel.checkpoint. The new solution avoids that error, but does miss cases like:

from trio.lowlevel import Timer

Where it could insert from trio.lowlevel import Timer, checkpoint. Instead, it'll add from trio import lowlevel.

See: #8402 (comment)

@charliermarsh charliermarsh enabled auto-merge (squash) November 17, 2023 01:04
@charliermarsh charliermarsh added the bug Something isn't working label Nov 17, 2023
@charliermarsh charliermarsh merged commit 1fcccf8 into main Nov 17, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/trio-lowlevel branch November 17, 2023 01:08
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@charliermarsh