Improve B005 documentation to reflect duplicate-character behavior
#7601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/B005
branch
from
d209414
to
471a3d8
Compare
MichaReiser
approved these changes
Sep 22, 2023
Comment on lines
+32
to
+33
| /// while the use of duplicate-character strings is very likely to be a | ||
| /// mistake. |
CodSpeed Performance ReportMerging #7601 will degrade performances by 3.15%Comparing Summary
Benchmarks breakdown
|
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+8, -8, 0 error(s)) airflow (+2, -2)
+ airflow/providers/qubole/hooks/qubole.py:87:21: B005 Using `.strip()` with multi-character strings is misleading - airflow/providers/qubole/hooks/qubole.py:87:21: B005 Using `.strip()` with multi-character strings is misleading the reader + scripts/ci/pre_commit/pre_commit_lint_dockerfile.py:57:15: B005 Using `.strip()` with multi-character strings is misleading - scripts/ci/pre_commit/pre_commit_lint_dockerfile.py:57:15: B005 Using `.strip()` with multi-character strings is misleading the reader bokeh (+2, -2)
+ src/bokeh/plotting/_graph.py:138:20: B005 Using `.strip()` with multi-character strings is misleading - src/bokeh/plotting/_graph.py:138:20: B005 Using `.strip()` with multi-character strings is misleading the reader + src/bokeh/plotting/_graph.py:138:78: B005 Using `.strip()` with multi-character strings is misleading - src/bokeh/plotting/_graph.py:138:78: B005 Using `.strip()` with multi-character strings is misleading the reader content (+4, -4)
+ Packs/Cryptocurrency/Integrations/Cryptocurrency/Cryptocurrency.py:61:41: B005 Using `.strip()` with multi-character strings is misleading - Packs/Cryptocurrency/Integrations/Cryptocurrency/Cryptocurrency.py:61:41: B005 Using `.strip()` with multi-character strings is misleading the reader + Packs/PcapAnalysis/Scripts/PcapMinerV2/PcapMinerV2.py:138:38: B005 Using `.strip()` with multi-character strings is misleading - Packs/PcapAnalysis/Scripts/PcapMinerV2/PcapMinerV2.py:138:38: B005 Using `.strip()` with multi-character strings is misleading the reader + Packs/SimpleDebugger/Scripts/SimpleDebugger/SimpleDebugger.py:260:42: B005 Using `.strip()` with multi-character strings is misleading - Packs/SimpleDebugger/Scripts/SimpleDebugger/SimpleDebugger.py:260:42: B005 Using `.strip()` with multi-character strings is misleading the reader + Packs/URLHaus/Integrations/URLHaus/URLHaus.py:655:37: B005 Using `.strip()` with multi-character strings is misleading - Packs/URLHaus/Integrations/URLHaus/URLHaus.py:655:37: B005 Using `.strip()` with multi-character strings is misleading the reader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
B005 only flags
.strip()calls for which the argument includes duplicate characters. This is consistent with bugbear, but isn't explained in the documentation.