Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwrap in os_error_alias.rs #7583

Merged
merged 1 commit into from Sep 21, 2023
Merged

Remove unwrap in os_error_alias.rs #7583

merged 1 commit into from Sep 21, 2023

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Sep 21, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) September 21, 2023 21:10
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2023

CodSpeed Performance Report

Merging #7583 will degrade performances by 2.29%

Comparing charlie/panic (ba0a7f7) with main (74dbd87)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/panic Change
❌ linter/default-rules[large/dataset.py] 92 ms 94.1 ms -2.29%

@charliermarsh charliermarsh merged commit f254aaa into main Sep 21, 2023
15 of 16 checks passed
@charliermarsh charliermarsh deleted the charlie/panic branch September 21, 2023 21:19
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@charliermarsh