Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PLE2510, PLE2512-2515 to check in f-strings #7296

Closed
Tracked by #7299
dhruvmanila opened this issue Sep 12, 2023 · 0 comments · Fixed by #7387
Closed
Tracked by #7299

Update PLE2510, PLE2512-2515 to check in f-strings #7296

dhruvmanila opened this issue Sep 12, 2023 · 0 comments · Fixed by #7387
Assignees
@dhruvmanila
Labels
python312 Related to Python 3.12 rule Implementing or modifying a lint rule

Comments

@dhruvmanila
Copy link
Member

PLE2510, PLE2512, PLE2513, PLE2514, and PLE2515 checks for invalid string characters.

The rule needs to be updated to check within the f-string as well. Here, we only need to check within the FStringMiddle token which contains the non-expression part of a f-string.
@dhruvmanila dhruvmanila mentioned this issue Sep 12, 2023
Closed
9 tasks
@dhruvmanila dhruvmanila added python312 Related to Python 3.12 rule Implementing or modifying a lint rule labels Sep 12, 2023
@dhruvmanila dhruvmanila self-assigned this Sep 14, 2023
@dhruvmanila dhruvmanila linked a pull request Sep 14, 2023 that will close this issue
Update PLE2510, PLE2512-2515 to check in f-strings #7387
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
python312 Related to Python 3.12 rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PLE2510, PLE2512-2515 to check in f-strings astral-sh/ruff
1 participant
@dhruvmanila