Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏖️ Formatter Preview style #6935

Closed
9 of 12 tasks
MichaReiser opened this issue Aug 28, 2023 · 7 comments
Closed
9 of 12 tasks

🏖️ Formatter Preview style #6935

MichaReiser opened this issue Aug 28, 2023 · 7 comments
Labels
formatter Related to the formatter preview Related to preview mode features

Comments

@MichaReiser
Copy link
Member

MichaReiser commented Aug 28, 2023 •
edited by zanieb

This is an umbrella issue to track the progress towards supporting the preview style
@MichaReiser MichaReiser added the formatter Related to the formatter label Aug 28, 2023
@MichaReiser MichaReiser added this to the Formatter: Stable milestone Aug 28, 2023
This was referenced Sep 2, 2023
Closed
Closed
@MichaReiser MichaReiser added the preview Related to preview mode features label Sep 15, 2023
@MichaReiser MichaReiser changed the title 🏖️ Black Preview style 🏖️ Formatter Preview style Oct 17, 2023
@MichaReiser MichaReiser mentioned this issue Oct 18, 2023
Closed
@mkniewallner mkniewallner mentioned this issue Oct 28, 2023
Merged
4 tasks
@jab jab mentioned this issue Oct 30, 2023
Closed
@konstin
Copy link
Member

konstin commented Nov 14, 2023

I wrote up the state and TODOs of compatibility for the planned 2024 black stable style: #8678. Some of the items listed here are not included, e.g. the improved string processing

@MichaReiser
Copy link
Member Author

I wrote up the state and TODOs of compatibility for the planned 2024 black stable style: #8678. Some of the items listed here are not included, e.g. the improved string processing

Thanks. I'll have a closer look once I manage to get through all notifications 😅

@MichaReiser
Copy link
Member Author

Closing in favor of #8678

@MichaReiser MichaReiser closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
@MichaReiser MichaReiser removed this from the Formatter: Stable milestone Nov 29, 2023
@zanieb
Copy link
Member

zanieb commented Nov 29, 2023

@MichaReiser I actually liked having this issue for general preview formatter style discussion whereas #8678 is specifically for the 2024 Black preview implementations.

@charliermarsh
Copy link
Member

FWIW I'm fine with closing this, I don't really see the value it adds to track here separately. Shouldn't we use a discussion if we want to gather feedback on preview style, not this issue?

@MichaReiser
Copy link
Member Author

@zanieb feel free to take the issue over and update its content. I closed it because the content it tracked is now identical to #8678. I don't mind keeping it around, if it serves a different purpose.

@zanieb
Copy link
Member

zanieb commented Nov 29, 2023

Hm... let's leave it closed for now and we can re-open or create a new one if we need it later.

@MichaReiser MichaReiser mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formatter Related to the formatter preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MichaReiser @charliermarsh @zanieb @konstin