Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Notebook related symbols #6862

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Rename Notebook related symbols #6862

merged 2 commits into from
Aug 25, 2023

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Aug 25, 2023

This PR renames the following symbols:

  • PySourceType::Jupyter -> PySourceType::Ipynb
  • SourceKind::Jupyter -> SourceKind::IpyNotebook
  • JupyterIndex -> NotebookIndex

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila force-pushed the dhruv/ipy-rename branch 2 times, most recently from f2d5688 to 761bf8c Compare August 25, 2023 03:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      4.7±0.02ms     8.6 MB/sec    1.00      4.7±0.02ms     8.7 MB/sec
formatter/numpy/ctypeslib.py               1.01    989.0±4.62µs    16.8 MB/sec    1.00    983.4±6.13µs    16.9 MB/sec
formatter/numpy/globals.py                 1.00     93.3±0.72µs    31.6 MB/sec    1.01     93.9±0.90µs    31.4 MB/sec
formatter/pydantic/types.py                1.00  1947.1±11.60µs    13.1 MB/sec    1.00  1946.7±14.78µs    13.1 MB/sec
linter/all-rules/large/dataset.py          1.00     12.1±0.03ms     3.4 MB/sec    1.00     12.0±0.04ms     3.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      3.3±0.01ms     5.1 MB/sec    1.00      3.2±0.01ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.01    460.8±0.95µs     6.4 MB/sec    1.00    457.7±2.13µs     6.4 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.3±0.01ms     4.0 MB/sec    1.00      6.3±0.02ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.01      6.5±0.01ms     6.3 MB/sec    1.00      6.4±0.02ms     6.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1438.0±2.92µs    11.6 MB/sec    1.00   1436.6±6.51µs    11.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    168.7±0.28µs    17.5 MB/sec    1.00    168.0±0.53µs    17.6 MB/sec
linter/default-rules/pydantic/types.py     1.01      2.9±0.01ms     8.7 MB/sec    1.00      2.9±0.01ms     8.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      5.8±0.23ms     7.0 MB/sec    1.00      5.8±0.16ms     7.0 MB/sec
formatter/numpy/ctypeslib.py               1.00  1196.2±64.28µs    13.9 MB/sec    1.01  1206.5±54.94µs    13.8 MB/sec
formatter/numpy/globals.py                 1.00   118.0±12.90µs    25.0 MB/sec    1.00    117.5±7.21µs    25.1 MB/sec
formatter/pydantic/types.py                1.00      2.4±0.11ms    10.6 MB/sec    1.01      2.4±0.12ms    10.5 MB/sec
linter/all-rules/large/dataset.py          1.01     15.8±0.37ms     2.6 MB/sec    1.00     15.7±0.46ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.3±0.13ms     3.8 MB/sec    1.00      4.3±0.12ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.02   550.8±25.09µs     5.4 MB/sec    1.00   540.2±24.01µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.3±0.30ms     3.1 MB/sec    1.00      8.2±0.26ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.00      8.8±0.20ms     4.6 MB/sec    1.00      8.8±0.25ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1872.0±96.02µs     8.9 MB/sec    1.01  1896.6±71.97µs     8.8 MB/sec
linter/default-rules/numpy/globals.py      1.00   224.6±13.41µs    13.1 MB/sec    1.00   224.4±12.70µs    13.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.0±0.13ms     6.4 MB/sec    1.00      4.0±0.16ms     6.4 MB/sec

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Aug 25, 2023
@dhruvmanila dhruvmanila merged commit d1f0700 into main Aug 25, 2023
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/ipy-rename branch August 25, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants