Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump static Python versions in CI from 3.7 to 3.11 #5700

Merged
merged 3 commits into from Jul 12, 2023
Merged

Bump static Python versions in CI from 3.7 to 3.11 #5700

merged 3 commits into from Jul 12, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 12, 2023 •
edited

Python 3.7 is EOL and we should use the latest stable version for builds.

Related to astral-sh/ruff-lsp#189

@zanieb
Bump static Python versions in CI from 3.7 to 3.11
d6b37cb 
Python 3.7 is EOL and we should use the latest stable version for builds.
@zanieb
Use env.PYTHON_VERSION consistently
5a14d24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      8.4±0.01ms     4.9 MB/sec    1.00      8.4±0.02ms     4.9 MB/sec
formatter/numpy/ctypeslib.py               1.00   1896.8±2.76µs     8.8 MB/sec    1.00   1896.3±1.83µs     8.8 MB/sec
formatter/numpy/globals.py                 1.00    203.6±0.20µs    14.5 MB/sec    1.01    205.0±0.32µs    14.4 MB/sec
formatter/pydantic/types.py                1.00      4.2±0.01ms     6.1 MB/sec    1.01      4.2±0.01ms     6.0 MB/sec
linter/all-rules/large/dataset.py          1.00     13.9±0.01ms     2.9 MB/sec    1.02     14.2±0.02ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.7 MB/sec    1.01      3.5±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    365.5±1.72µs     8.1 MB/sec    1.00    365.3±4.02µs     8.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.2±0.01ms     4.1 MB/sec    1.01      6.3±0.01ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.0±0.01ms     5.8 MB/sec    1.01      7.1±0.01ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1445.5±2.68µs    11.5 MB/sec    1.02   1476.0±2.47µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    155.4±0.22µs    19.0 MB/sec    1.01    157.6±1.09µs    18.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.01ms     8.1 MB/sec    1.01      3.2±0.01ms     8.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.15     11.2±0.20ms     3.6 MB/sec    1.00      9.8±0.26ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.12      2.4±0.04ms     6.9 MB/sec    1.00      2.2±0.04ms     7.7 MB/sec
formatter/numpy/globals.py                 1.07    260.0±6.82µs    11.3 MB/sec    1.00    242.0±9.03µs    12.2 MB/sec
formatter/pydantic/types.py                1.11      5.3±0.12ms     4.8 MB/sec    1.00      4.8±0.16ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.00     16.9±0.33ms     2.4 MB/sec    1.09     18.4±0.27ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.4±0.12ms     3.8 MB/sec    1.06      4.7±0.14ms     3.6 MB/sec
linter/all-rules/numpy/globals.py          1.00    511.5±9.94µs     5.8 MB/sec    1.05   536.5±11.27µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.5±0.16ms     3.4 MB/sec    1.06      8.0±0.16ms     3.2 MB/sec
linter/default-rules/large/dataset.py      1.00      8.4±0.15ms     4.8 MB/sec    1.20     10.1±0.15ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1779.7±30.38µs     9.4 MB/sec    1.14      2.0±0.02ms     8.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    201.3±4.82µs    14.7 MB/sec    1.12    225.2±7.42µs    13.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.06ms     6.8 MB/sec    1.16      4.3±0.07ms     5.9 MB/sec

@zanieb @konstin
Remove abi3 wheel comments
df04093 
> PyO3 has feature flags abi3-py37, abi3-py38, abi3-py39 etc. to set the minimum required Python version for your abi3 wheel. For example, if you set the abi3-py37 feature, your extension wheel can be used on all Python 3 versions from Python 3.7 and up
> 
> PyO3 is only able to link your extension module to abi3 version up to and including your host Python version. E.g., if you set abi3-py38 and try to compile the crate with a host of Python 3.7, the build will fail.

Co-authored-by: konsti <konstin@mailbox.org>
@zanieb zanieb enabled auto-merge (squash) July 12, 2023 13:49
@zanieb zanieb merged commit 5665968 into astral-sh:main Jul 12, 2023
15 checks passed
konstin added a commit that referenced this pull request Jul 19, 2023
@zanieb @konstin
Bump static Python versions in CI from 3.7 to 3.11 (#5700)
7861192 
Python 3.7 is EOL and we should use the latest stable version for
builds.

Related to astral-sh/ruff-lsp#189

---------

Co-authored-by: konsti <konstin@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh left review comments

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zanieb @charliermarsh @konstin