More stability checker options #5299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
MichaReiser
approved these changes
Jun 22, 2023
| @@ -54,6 +57,33 @@ struct WrapperArgs { | |||
| } | |||
|
|
|||
| pub(crate) fn main(args: &Args) -> anyhow::Result<ExitCode> { | |||
| let all_success = if args.multi_project { | |||
| let mut all_success = true; | |||
| for dir in args.files[0].read_dir()? { | |||
There was a problem hiding this comment.
that should have been only my dummy, fixed
konstin
added a commit
that referenced
this pull request
Jul 13, 2023
## Summary These changes make `scripts/ecosystem_all_check.sh --select ALL` work again, i forgot to update this script to the new directory structure from #5299 because it's only run manually ## Test Plan n/a
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 19, 2023
## Summary These changes make `scripts/ecosystem_all_check.sh --select ALL` work again, i forgot to update this script to the new directory structure from astral-sh#5299 because it's only run manually ## Test Plan n/a
konstin
added a commit
that referenced
this pull request
Jul 19, 2023
## Summary These changes make `scripts/ecosystem_all_check.sh --select ALL` work again, i forgot to update this script to the new directory structure from #5299 because it's only run manually ## Test Plan n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This contains three changes:
check_ecosystem.pyare stored asorg:nameinstead oforg/nameto create a flat directory layoutcheck_ecosystem.pyperforms a maximum of 50 parallel jobs at the same time to avoid consuming to much RAMcheck-formatter-stabilitygets a new option--multi-projectso it's possible to docargo run --bin ruff_dev -- check-formatter-stability --multi-project target/checkoutsWith these three changes it becomes easy to check the formatter stability over a larger number of repositories. This is part of the integration of integrating formatter regressions checks into the ecosystem checks.
Test Plan