Fix formatter panic with comment after parenthesized dict value #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
MichaReiser
reviewed
Jun 22, 2023
| .. | ||
| } | ||
| )); | ||
| while let Some(first) = tokens.next() { |
There was a problem hiding this comment.
Could we add '{'.text_len() on line 982 instead of skipping over the { in the iteration?
There was a problem hiding this comment.
i tried it, but this didn't work for me
konstin
force-pushed
the
Fix_formatter_panic_with_comment_after_parenthesized_dict_value
branch
from
d6f0cd1
to
8010d93
Compare
## Summary
This snippet used to panic because it expected to see a comma or something similar after the `2` but met the closing parentheses that is not part of the range and panicked
```python
a = {
1: (2),
# comment
3: True,
}
```
Originally found in https://github.com/bolucat/Firefox/blob/636a717ef025c16434997dc89e42351ef740ee6b/testing/marionette/client/marionette_driver/geckoinstance.py#L109
This snippet is also the test plan.
konstin
force-pushed
the
Fix_formatter_panic_with_comment_after_parenthesized_dict_value
branch
from
8010d93
to
b963c7f
Compare
MichaReiser
approved these changes
Jun 22, 2023
konstin
deleted the
Fix_formatter_panic_with_comment_after_parenthesized_dict_value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This snippet used to panic because it expected to see a comma or something similar after the
2but met the closing parentheses that is not part of the range and panickedOriginally found in https://github.com/bolucat/Firefox/blob/636a717ef025c16434997dc89e42351ef740ee6b/testing/marionette/client/marionette_driver/geckoinstance.py#L109
This snippet is also the test plan.