Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C416 rule with dict comprehensions and make autofixable #3598

Closed
Skylion007 opened this issue Mar 18, 2023 · 2 comments · Fixed by #3605
Closed

Update C416 rule with dict comprehensions and make autofixable #3598

Skylion007 opened this issue Mar 18, 2023 · 2 comments · Fixed by #3605
Assignees
@dhruvmanila
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule

Comments

@Skylion007
Copy link

I recently updated flake8-comprehension's C416 check to extend to dict comprehensions as well. It should also be auto-fixable just like the other C416 checks. Since the new version is now released on PyPy, it is a good idea to update to it.
@charliermarsh
Copy link
Member

Sweet, thanks for the heads up.

@charliermarsh charliermarsh added good first issue Good for newcomers rule Implementing or modifying a lint rule labels Mar 18, 2023
@Skylion007 Skylion007 mentioned this issue Mar 19, 2023
Closed
@dhruvmanila
Copy link
Member

Hi, can I take this?

@dhruvmanila dhruvmanila mentioned this issue Mar 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update C416 with dict comprehension (autofixable) dhruvmanila/ruff
3 participants
@charliermarsh @Skylion007 @dhruvmanila