[red-knot] MDTest: Use custom class names instead of builtins #16269
+359
−282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
added
testing
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
sharkdp
commented
Feb 20, 2025
crates/red_knot_python_semantic/resources/mdtest/exception/control_flow.md
Show resolved
Hide resolved
AlexWaygood
approved these changes
Feb 20, 2025
crates/red_knot_python_semantic/resources/mdtest/comparison/tuples.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/exception/control_flow.md
Show resolved
Hide resolved
sharkdp
force-pushed
the
david/opaque-type-names
branch
from
fd0641d to
091c3f7
Compare
sharkdp
commented
Feb 20, 2025
crates/red_knot_python_semantic/resources/mdtest/comparison/instances/rich_comparison.md
Show resolved
Hide resolved
sharkdp
force-pushed
the
david/opaque-type-names
branch
from
091c3f7 to
42b4843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the discussion here. Replace builtin classes with custom placeholder names, which should hopefully make the tests a bit easier to understand.
I carefully renamed things one after the other, to make sure that there is no functional change in the tests.