Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with an error if there are check failures #12735

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Exit with an error if there are check failures #12735

merged 2 commits into from
Aug 8, 2024
+95 −37

Conversation

MichaReiser
Copy link
Member

Summary

This PR copies the behavior from Ruff to exit with 1 if there are linting errors and 0 otherwise.

Test Plan

  • I ran Red Knot on a directory with linting errors and verified that the exit code is 1.
  • I ran Red Knot on a directory without linting errors and verified that the exit code is 0.

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Aug 7, 2024
AlexWaygood
AlexWaygood approved these changes Aug 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Base automatically changed from red-knot-tracing to main August 8, 2024 06:28
@MichaReiser
Exit with an error if there are check failures

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
6d6298a
@MichaReiser
Simplify From<ExitStatus> implementation

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
Loading
Loading status checks…
9fff205
@MichaReiser MichaReiser enabled auto-merge (squash) August 8, 2024 07:06
@MichaReiser MichaReiser merged commit df7345e into main Aug 8, 2024
16 checks passed
@MichaReiser MichaReiser deleted the add-exit-code branch August 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm

@AlexWaygood AlexWaygood

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaReiser @carljm @AlexWaygood