Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd ecosystem results on typeshed #11305

Open
AlexWaygood opened this issue May 6, 2024 · 2 comments
Open

Odd ecosystem results on typeshed #11305

AlexWaygood opened this issue May 6, 2024 · 2 comments
Labels
ci Related to internal CI tooling

Comments

@AlexWaygood
Copy link
Member

Seems like there's something up with the ecosystem check when it runs on typeshed currently. We've had issues on several PRs where the ecosystem check has produced surprising results that don't make logical sense and can't be reproduced locally:

No idea what's up here

@MichaReiser
Copy link
Member

Would you mind listing some of the "odd" examples and explaining why they're odd?

@AlexWaygood
Copy link
Member Author

AlexWaygood commented May 6, 2024

Would you mind listing some of the "odd" examples and explaining why they're odd?

In all three comments I linked to above, the ecosystem check either surfaced new lint errors that could not be reproduced locally when running ruff with the PR branch, and/or failed to report errors going away even though locally running ruff with the PR branch led to existing lint errors going away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

No branches or pull requests

2 participants