Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check for RUF020 enabled #11268

Merged
merged 1 commit into from
May 3, 2024
Merged

Remove unnecessary check for RUF020 enabled #11268

merged 1 commit into from
May 3, 2024

Conversation

tusharsadhwani
Copy link
Contributor

Summary

In #9218 Rule::NeverUnion was partially removed from a checker.any_enabled call. This makes the change consistent.

Test Plan

cargo test

zanieb
zanieb approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the internal An internal refactor or improvement label May 3, 2024
@zanieb zanieb enabled auto-merge (squash) May 3, 2024 18:14
@zanieb zanieb merged commit f3284fd into astral-sh:main May 3, 2024
19 checks passed
@tusharsadhwani tusharsadhwani deleted the typo-never-union branch May 3, 2024 18:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tusharsadhwani @zanieb