Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] resolve class members #11256

Merged
merged 4 commits into from
May 3, 2024
Merged

[red-knot] resolve class members #11256

merged 4 commits into from
May 3, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented May 3, 2024

Summary

Add the ability to (lazily) resolve members of a class type.

Test Plan

cargo test

@carljm @AlexWaygood
[red-knot] resolve class members
5e70008 
Co-authored-by: Alex Waygood <Alex.Waygood@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 3, 2024
MichaReiser
MichaReiser approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

What's unclear to me is whether we use the FileId on ClassType, considering that it is already part of ClassTypeId.

crates/red_knot/src/symbols.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted all the code I wrote yesterday with you 😭

j/k, it makes sense to do this lazily! Left some questions below, but basically looks good

crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
@carljm carljm merged commit 82dd5e6 into main May 3, 2024
19 checks passed
@carljm carljm deleted the cjm/class-methods branch May 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@plredmond plredmond Awaiting requested review from plredmond

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carljm @MichaReiser @AlexWaygood