Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase rationale for pytest-incorrect-pytest-import #11255

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

Closes #11247.

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label May 3, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) May 3, 2024 00:46
@charliermarsh charliermarsh merged commit 9e69cd6 into main May 3, 2024
19 checks passed
@charliermarsh charliermarsh deleted the charlie/pt branch May 3, 2024 00:51
Copy link
Contributor

github-actions bot commented May 3, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+25 -25 violations, +0 -0 fixes in 2 projects; 42 projects unchanged)

bokeh/bokeh (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- tests/unit/bokeh/models/test_callbacks__models.py:24:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ tests/unit/bokeh/models/test_callbacks__models.py:24:1: PT013 Incorrect import of `pytest`; use `import pytest` instead

demisto/content (+24 -24 violations, +0 -0 fixes)

- Packs/Absolute/Integrations/Absolute/Absolute_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Absolute/Integrations/Absolute/Absolute_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/ApiModules/Scripts/AWSApiModule/AWSApiModule_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/ApiModules/Scripts/AWSApiModule/AWSApiModule_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/BMCDiscovery/Integrations/BMCDiscovery/BMCDiscovery_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/BMCDiscovery/Integrations/BMCDiscovery/BMCDiscovery_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/CadoResponse/Integrations/CadoResponse/CadoResponse_test.py:8:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/CadoResponse/Integrations/CadoResponse/CadoResponse_test.py:8:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/DeprecatedContent/Integrations/PaloAltoNetworksCortex/PaloAltoNetworksCortex_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/DeprecatedContent/Integrations/PaloAltoNetworksCortex/PaloAltoNetworksCortex_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/GreyNoise/Integrations/GreyNoise/GreyNoise_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/GreyNoise/Integrations/GreyNoise/GreyNoise_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/GuardiCore/Integrations/GuardiCoreV2/GuardiCoreV2_test.py:6:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/GuardiCore/Integrations/GuardiCoreV2/GuardiCoreV2_test.py:6:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/HPEArubaClearPass/Integrations/HPEArubaClearPass/HPEArubaClearPass_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/HPEArubaClearPass/Integrations/HPEArubaClearPass/HPEArubaClearPass_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/Inventa/Integrations/Inventa/Inventa_test.py:15:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Inventa/Integrations/Inventa/Inventa_test.py:15:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/Lokpath_Keylight/Scripts/KeylightCreateIssue/KeylightCreateIssue_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Lokpath_Keylight/Scripts/KeylightCreateIssue/KeylightCreateIssue_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/MobileIronUEM/Integrations/MobileIronCORE/MobileIronCORE_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/MobileIronUEM/Integrations/MobileIronCORE/MobileIronCORE_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/PcapAnalysis/Scripts/PcapFileExtractor/PcapFileExtractor_test.py:8:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/PcapAnalysis/Scripts/PcapFileExtractor/PcapFileExtractor_test.py:8:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/PhishUp/Integrations/PhishUp/PhishUp_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/PhishUp/Integrations/PhishUp/PhishUp_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/RecordedFuture/Integrations/RecordedFutureLists/RecordedFutureLists_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/RecordedFuture/Integrations/RecordedFutureLists/RecordedFutureLists_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SingleConnect/Integrations/SingleConnect/SingleConnect_test.py:2:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SingleConnect/Integrations/SingleConnect/SingleConnect_test.py:2:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SophosCentral/Integrations/SophosCentral/SophosCentral_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SophosCentral/Integrations/SophosCentral/SophosCentral_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SplunkPy/Scripts/SplunkShowDrilldown/SplunkShowDrilldown_test.py:2:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SplunkPy/Scripts/SplunkShowDrilldown/SplunkShowDrilldown_test.py:2:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SymantecDLP/Integrations/SymantecDLP/SymantecDLP_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SymantecDLP/Integrations/SymantecDLP/SymantecDLP_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SymantecDLP/Integrations/SymantecDLPV2/SymantecDLPV2_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SymantecDLP/Integrations/SymantecDLPV2/SymantecDLPV2_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/AnalyticsAndSIEM/AnalyticsAndSIEM_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/AnalyticsAndSIEM/AnalyticsAndSIEM_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/Authentication/Authentication_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/Authentication/Authentication_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/CaseManagement/CaseManagement_test.py:6:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/CaseManagement/CaseManagement_test.py:6:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/DataEnrichmentThreatIntelligence/DataEnrichmentThreatIntelligence_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/DataEnrichmentThreatIntelligence/DataEnrichmentThreatIntelligence_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PT013 50 25 25 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+25 -25 violations, +0 -0 fixes in 2 projects; 42 projects unchanged)

bokeh/bokeh (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- tests/unit/bokeh/models/test_callbacks__models.py:24:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ tests/unit/bokeh/models/test_callbacks__models.py:24:1: PT013 Incorrect import of `pytest`; use `import pytest` instead

demisto/content (+24 -24 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- Packs/Absolute/Integrations/Absolute/Absolute_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Absolute/Integrations/Absolute/Absolute_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/ApiModules/Scripts/AWSApiModule/AWSApiModule_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/ApiModules/Scripts/AWSApiModule/AWSApiModule_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/BMCDiscovery/Integrations/BMCDiscovery/BMCDiscovery_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/BMCDiscovery/Integrations/BMCDiscovery/BMCDiscovery_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/CadoResponse/Integrations/CadoResponse/CadoResponse_test.py:8:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/CadoResponse/Integrations/CadoResponse/CadoResponse_test.py:8:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/DeprecatedContent/Integrations/PaloAltoNetworksCortex/PaloAltoNetworksCortex_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/DeprecatedContent/Integrations/PaloAltoNetworksCortex/PaloAltoNetworksCortex_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/GreyNoise/Integrations/GreyNoise/GreyNoise_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/GreyNoise/Integrations/GreyNoise/GreyNoise_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/GuardiCore/Integrations/GuardiCoreV2/GuardiCoreV2_test.py:6:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/GuardiCore/Integrations/GuardiCoreV2/GuardiCoreV2_test.py:6:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/HPEArubaClearPass/Integrations/HPEArubaClearPass/HPEArubaClearPass_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/HPEArubaClearPass/Integrations/HPEArubaClearPass/HPEArubaClearPass_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/Inventa/Integrations/Inventa/Inventa_test.py:15:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Inventa/Integrations/Inventa/Inventa_test.py:15:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/Lokpath_Keylight/Scripts/KeylightCreateIssue/KeylightCreateIssue_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/Lokpath_Keylight/Scripts/KeylightCreateIssue/KeylightCreateIssue_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/MobileIronUEM/Integrations/MobileIronCORE/MobileIronCORE_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/MobileIronUEM/Integrations/MobileIronCORE/MobileIronCORE_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/PcapAnalysis/Scripts/PcapFileExtractor/PcapFileExtractor_test.py:8:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/PcapAnalysis/Scripts/PcapFileExtractor/PcapFileExtractor_test.py:8:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/PhishUp/Integrations/PhishUp/PhishUp_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/PhishUp/Integrations/PhishUp/PhishUp_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/RecordedFuture/Integrations/RecordedFutureLists/RecordedFutureLists_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/RecordedFuture/Integrations/RecordedFutureLists/RecordedFutureLists_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SingleConnect/Integrations/SingleConnect/SingleConnect_test.py:2:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SingleConnect/Integrations/SingleConnect/SingleConnect_test.py:2:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SophosCentral/Integrations/SophosCentral/SophosCentral_test.py:5:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SophosCentral/Integrations/SophosCentral/SophosCentral_test.py:5:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SplunkPy/Scripts/SplunkShowDrilldown/SplunkShowDrilldown_test.py:2:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SplunkPy/Scripts/SplunkShowDrilldown/SplunkShowDrilldown_test.py:2:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SymantecDLP/Integrations/SymantecDLP/SymantecDLP_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SymantecDLP/Integrations/SymantecDLP/SymantecDLP_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Packs/SymantecDLP/Integrations/SymantecDLPV2/SymantecDLPV2_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Packs/SymantecDLP/Integrations/SymantecDLPV2/SymantecDLPV2_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/AnalyticsAndSIEM/AnalyticsAndSIEM_test.py:3:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/AnalyticsAndSIEM/AnalyticsAndSIEM_test.py:3:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/Authentication/Authentication_test.py:1:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/Authentication/Authentication_test.py:1:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/CaseManagement/CaseManagement_test.py:6:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/CaseManagement/CaseManagement_test.py:6:1: PT013 Incorrect import of `pytest`; use `import pytest` instead
- Templates/Integrations/DataEnrichmentThreatIntelligence/DataEnrichmentThreatIntelligence_test.py:7:1: PT013 Found incorrect import of pytest, use simple `import pytest` instead
+ Templates/Integrations/DataEnrichmentThreatIntelligence/DataEnrichmentThreatIntelligence_test.py:7:1: PT013 Incorrect import of `pytest`; use `import pytest` instead

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PT013 50 25 25 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PT013] Rationale is unconvincing.
1 participant