Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lexical error types #11145

Merged
merged 1 commit into from Apr 25, 2024
Merged

Remove unused lexical error types #11145

merged 1 commit into from Apr 25, 2024

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Apr 25, 2024 •
edited

Most of them have been moved to the parser.

@dhruvmanila dhruvmanila added internal An internal refactor or improvement parser Related to the parser labels Apr 25, 2024
@dhruvmanila dhruvmanila enabled auto-merge (squash) April 25, 2024 15:16
charliermarsh
charliermarsh reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did they go? :)

@dhruvmanila
Copy link
Member Author

They've been moved to the parser.

dhruvmanila
dhruvmanila commented Apr 25, 2024
View reviewed changes
crates/ruff_python_parser/src/lexer.rs
Comment on lines -1416 to -1423
/// The nesting of brackets/braces/parentheses is not balanced.
NestingError,
/// The indentation is not consistent.
IndentationError,
/// Inconsistent use of tabs and spaces.
TabError,
/// Encountered a tab after a space.
TabsAfterSpaces,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about these 3 although they are never used.

@dhruvmanila dhruvmanila merged commit 4738e19 into main Apr 25, 2024
18 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/remove-unused-lexical-error branch April 25, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement parser Related to the parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvmanila @charliermarsh