Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider binary expr for parenthesized with items parsing #11012

Merged
merged 1 commit into from Apr 18, 2024
Merged

Consider binary expr for parenthesized with items parsing #11012

merged 1 commit into from Apr 18, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This PR fixes the bug in with items parsing where it would fail to recognize that the parenthesized expression is part of a large binary expression.

Test Plan

Add test cases and verified the snapshots.

@dhruvmanila dhruvmanila added bug Something isn't working parser Related to the parser labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila dhruvmanila merged commit b7066e6 into main Apr 18, 2024
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/with-items-binary-expr branch April 18, 2024 16:09
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working parser Related to the parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvmanila @MichaReiser