Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N815: TypedDict Subclasses are not ignored #10774

Closed
Zer0x00 opened this issue Apr 4, 2024 · 1 comment
Closed

N815: TypedDict Subclasses are not ignored #10774

Zer0x00 opened this issue Apr 4, 2024 · 1 comment

Comments

@Zer0x00
Copy link

Zer0x00 commented Apr 4, 2024

In #4066 a routine was implemented to ignore TypedDicts from N815 (mixed-case-variable-in-class-scope). But subclasses are not respected from the ignore rule for TypedDicts.

from typing import TypedDict


class Baseclass(TypedDict):
    camelCaseOK: str # No violation


class Subclass(Baseclass):
    camelCaseNotOK: str # Violation! But should not violate because it is a subclass of Baseclass
@AlexWaygood
Copy link
Member

Thanks for opening the issue! Luckily, this was fixed three days ago in #10719, so shouldn't be an issue once the next release comes out :-)

Closing as a duplicate of #10671

@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants