Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing comments after supression comments #10343

Open
zanieb opened this issue Mar 11, 2024 · 1 comment
Open

Allow trailing comments after supression comments #10343

zanieb opened this issue Mar 11, 2024 · 1 comment
Labels
help wanted Contributions especially welcome needs-design Needs further design before implementation suppression Related to supression of violations e.g. noqa

Comments

@zanieb
Copy link
Member

zanieb commented Mar 11, 2024

We should allow content to follow suppression comments e.g. to provide a reason for the # noqa.

We need to decide on a format to support with considerations of compatibility with other tools.

Previously discussed in:

@zanieb zanieb added suppression Related to supression of violations e.g. noqa help wanted Contributions especially welcome needs-design Needs further design before implementation labels Mar 11, 2024
@tylerlaprade
Copy link
Contributor

I have been using -- since it was encouraged by this ESLint rule.

I'm not personally too particular about the format. However, I think it would be wise to ensure compatibility with both Flake8 and Black since many incoming codebases are migrated from one or both.

I also think it's important that this enhancement does not break compatibility with Pyright/Mypy suppressions on the same line. This is not an uncommon occurrence, since something that violates the type system likely also violates one or more lint rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions especially welcome needs-design Needs further design before implementation suppression Related to supression of violations e.g. noqa
Projects
None yet
Development

No branches or pull requests

2 participants