Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat typing.Annotated subscripts as type definitions #10285

Merged
merged 1 commit into from Mar 8, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 8, 2024

Summary

I think this code has existed since the start of typing.Annotated support (#333), and was then overlooked over a series of refactors.

Closes #10279.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 57be3fc into main Mar 8, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/annotated branch March 8, 2024 00:51
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
)

## Summary

I think this code has existed since the start of `typing.Annotated`
support (astral-sh#333), and was then
overlooked over a series of refactors.

Closes astral-sh#10279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for string type hint in typing.Annotated
1 participant