Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refurb] Implement list_assign_reversed lint (FURB187) #10212

Merged
merged 3 commits into from Mar 21, 2024
Merged

[refurb] Implement list_assign_reversed lint (FURB187) #10212

merged 3 commits into from Mar 21, 2024

Conversation

alex-700
Copy link
Contributor

@alex-700 alex-700 commented Mar 3, 2024

Summary

Implement use_reverse (FURB187) lint.
Tests were copied from original https://github.com/dosisod/refurb/blob/master/test/data/err_187.py.

Test Plan

cargo test

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024 •
edited

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

apache/airflow (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/jobs/backfill_job_runner.py:901:13: FURB187 [*] Use of assignment of `reversed` on list `dagrun_infos`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FURB187 1 1 0 0 0

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Mar 4, 2024
@charliermarsh charliermarsh self-assigned this Mar 9, 2024
@charliermarsh charliermarsh self-requested a review March 9, 2024 00:01
charliermarsh
charliermarsh approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay.

@charliermarsh charliermarsh enabled auto-merge (squash) March 21, 2024 17:06
@charliermarsh charliermarsh merged commit 01fe268 into astral-sh:main Mar 21, 2024
17 checks passed
@alex-700 alex-700 deleted the latyshev/furb-187 branch March 22, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex-700 @charliermarsh @MichaReiser