Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.3.0 #10151

Merged
merged 10 commits into from Feb 29, 2024
Merged

Bump version to v0.3.0 #10151

merged 10 commits into from Feb 29, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Bump Ruff to v0.3

Test Plan

Copy link

github-actions bot commented Feb 28, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

pandas-dev/pandas (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pandas/_libs/tslib.pyi:21:5: PLR0917 Too many positional arguments (6/5)

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0917 1 1 0 0 0

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@Skylion007
Copy link

We aren't promoting any rules from preview in this release?

@charliermarsh
Copy link
Member

I want to hold off on promoting the pycodestyle rules (since we just added a bunch of new ones, and they still have some issues). The one set I could see us promoting around the refurb rules. They're quite complex but we don't receive many issues around them.

@MichaReiser
Copy link
Member Author

This is not ready to merge but ready to get early feedback on the new documentation

@MichaReiser MichaReiser marked this pull request as ready for review February 28, 2024 18:09
@Skylion007
Copy link

@charliermarsh Thoughts on the PERF lint rules?

@@ -606,44 +742,3 @@ df.drop(columns=["aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"]).drop_duplicates(a).rename
}
).to_csv(path / "aaaaaa.csv", index=False).other(a)
```

#### Expressions with (non-pragma) trailing comments are split more often ([#7823](https://github.com/astral-sh/ruff/issues/7823))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed this at some point

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice overall!

BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
crates/ruff_python_formatter/README.md Outdated Show resolved Hide resolved
crates/ruff_python_formatter/README.md Outdated Show resolved Hide resolved
crates/ruff_python_formatter/README.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@MichaReiser MichaReiser changed the title Ruff v0.3 Bump version to v0.3.0 Feb 29, 2024
@MichaReiser MichaReiser merged commit b53118e into main Feb 29, 2024
40 checks passed
@MichaReiser MichaReiser deleted the ruff-0.3 branch February 29, 2024 15:05
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
MichaReiser added a commit that referenced this pull request Mar 18, 2024
## Summary

#10151 documented the deviations between Ruff and Black with the new
2024 style guide in the `ruff-python-formatter/README.md`. However,
that's not the documentation shown
on the website when navigating to [intentional
deviations](https://docs.astral.sh/ruff/formatter/black/).

This PR streamlines the `ruff-python-formatter/README.md` and links to
the documentation on the website instead of repeating the same content.
The PR also makes the 2024 style guide deviations available on the
website documentation.

## Test Plan

I built the documentation locally and verified that the 2024 style guide
known deviations are now shown on the website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants