Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate whether a proposed fix is unsafe #342

Open
ThiefMaster opened this issue Nov 19, 2023 · 3 comments
Open

Indicate whether a proposed fix is unsafe #342

ThiefMaster opened this issue Nov 19, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ThiefMaster
Copy link

For example, this one would break the code (because is not cannot be overridden, so for certain SQLAlchemy comparisions, ==/!= comparisons against None are required):

image

Of course I know that it would not be safe to "fix" it, but maybe a less experienced developer might blindly apply the fix instead of adding noqa and then wonder why their code does not work.

@zanieb
Copy link
Member

zanieb commented Nov 19, 2023

I'm not sure how best to display this information. I worry that just appending "(unsafe)" would be confusing.

@ThiefMaster
Copy link
Author

⚠️ icon maybe?

@zanieb
Copy link
Member

zanieb commented Nov 19, 2023

I think in the long-run we'd want the ability to show why a fix is unsafe as well otherwise it doesn't seem helpful to the naive user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants