Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff-vscode fail silently when ruff.exe is deleted #270

Open
Tracked by #480
jackjyq opened this issue Aug 31, 2023 · 0 comments
Open
Tracked by #480

ruff-vscode fail silently when ruff.exe is deleted #270

jackjyq opened this issue Aug 31, 2023 · 0 comments

Comments

@jackjyq
Copy link

jackjyq commented Aug 31, 2023

When ruff.exe is deleted, e.g., been quarantined by antivirus software due to #196 , the ruff-vscode fails silently.

Environment

VSCode for Windows 11

Version: 1.81.1 (user setup)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:22:42.175Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.22621

ruff-vscode

Published 2022-11-8, 12:26:33
Last released 2023-8-21, 01:18:06
Last updated 2023-8-31, 14:41:23
Identifier charliermarsh.ruff

Reproduce

  • rename ~\.vscode\extensions\charliermarsh.ruff-2023.34.0-win32-x64\bundled\libs\bin\ruff.exe to ruff.exe.bak
  • The VSCode ruff linter feature fails silently
  • Manually triggering Ruff: fix all auto-fixing problems only pops up generic information, which is not helpful in resolving the issue.

image

  • Uninstalling and reinstalling ruff-vscode can not solve the issue.

It seems that the only solution is to remove the ~\.vscode\extensions\charliermarsh.ruff-2023.34.0-win32-x64\ folder and re-install ruff-vscode.

Expected behavior

  • The linter pops up a problem to indicate that the ruff.exe is not found rather than failing silently or popping up generic information.
  • Provide a way to fix ruff.exe rather than letting the user manually remove the folder, e.g. a new command called Ruff: re-install bundled ruff?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant