Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isSealed reflection-based implementation with JDK built-in implementation #3081

Open
scordio opened this issue Jun 12, 2023 · 2 comments
Open

Replace isSealed reflection-based implementation with JDK built-in implementation #3081

scordio opened this issue Jun 12, 2023 · 2 comments
Labels
language: Java 17+ An issue related to using AssertJ with Java 17 or newer status: ideal for contribution An issue that a contributor can help us with type: improvement A general improvement
Milestone
4.0.0

Comments

@scordio
Copy link
Member

scordio commented Jun 12, 2023

#3080 introduced a reflection-based implementation to assert that a Class instance is sealed.

We should replace such an implementation with the built-in Class::isSealed.
@scordio scordio added type: improvement A general improvement language: Java 17+ An issue related to using AssertJ with Java 17 or newer labels Jun 12, 2023
@scordio scordio added this to the 4.0.0 milestone Jun 12, 2023
@nicokosi
Copy link

nicokosi commented Oct 4, 2023

Hello, 👋
May I implement this issue? It would be my first AssertJ contribution, for hacktoberfest!

@scordio
Copy link
Member Author

scordio commented Oct 4, 2023

Thanks for the offer, @nicokosi!

We haven't started development on version 4 so this change will have to wait a little longer.

@scordio scordio added the Hackergarten An issue reserved for Hackergarten events (https://www.hackergarten.net/) label Apr 24, 2024
@scordio scordio added status: ideal for contribution An issue that a contributor can help us with and removed Hackergarten An issue reserved for Hackergarten events (https://www.hackergarten.net/) labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: Java 17+ An issue related to using AssertJ with Java 17 or newer status: ideal for contribution An issue that a contributor can help us with type: improvement A general improvement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@nicokosi @scordio