Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'Expecting code to raise a throwable' when lambda returns a value #3043

Open
findepi opened this issue May 14, 2023 · 4 comments
Open
Assignees
Labels
type: improvement A general improvement
Milestone

Comments

@findepi
Copy link
Contributor

findepi commented May 14, 2023

assertThatThrownBy throws "Expecting code to raise a throwable" when called code doesn't throw.
When test assertion fails, it's tempting to know what did the code do instead.

Enhance "Expecting code to raise a throwable" to mention produced value in case when the lambda is a producer.

@scordio
Copy link
Member

scordio commented Jan 2, 2024

The related change has been reverted in #3318 and the topic should be evaluated again together with #1652 and #2519.

@scordio scordio reopened this Jan 2, 2024
@scordio scordio modified the milestones: 3.25.0, 3.26.0 Jan 2, 2024
@scordio scordio added the type: improvement A general improvement label Jan 2, 2024
@scordio scordio self-assigned this Jan 2, 2024
@findepi
Copy link
Contributor Author

findepi commented Jan 4, 2024

@scordio apologies for #3314 and thank you for the quick revert.

@scordio
Copy link
Member

scordio commented Jan 5, 2024

No problem at all, @findepi! Unfortunately, we missed that potential breaking change but now we learned 🙂

@sbrannen
Copy link
Contributor

sbrannen commented Jan 9, 2024

@scordio scordio modified the milestones: 3.26.0, 3.27.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A general improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants