Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isInThePast and isInTheFuture to the missing Java 8 date/time types #2947

Closed

Conversation

StefanBratanov
Copy link
Contributor

Check List:

  • Add the missing assertions for Instant LocalDateTime OffsetDateTime ZonedDateTime since they follow the same patterns. Decided it makes sense to make them one PR.
  • Not sure if is necessary to implement invoke_api_method and verify_internal_effects for the ZonedDateTimeAssert and the OffsetDateTimeAssert tests. I implemented them as no-op.

@joel-costigliola
Copy link
Member

Integrated thanks @StefanBratanov !

@scordio scordio changed the title Add isInThePast and isInTheFuture to the missing java 8 date/time Add isInThePast and isInTheFuture to the missing Java 8 date/time Oct 22, 2023
@scordio scordio changed the title Add isInThePast and isInTheFuture to the missing Java 8 date/time Add isInThePast and isInTheFuture to the missing Java 8 date/time types Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding isPast() and isFuture() methods for asserting dates
2 participants