Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions #2580

Closed
wants to merge 1 commit into from
Closed

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Apr 19, 2022

As #2509 (comment) mentioned, several methods are added as the shortcuts for extracting boolean and numbers.

Check List:

@hezean
Copy link
Contributor Author

hezean commented Apr 20, 2022

Hi @scordio, sorry for bothering. This PR implements the methods you mentioned, could you please review the code?

@scordio
Copy link
Member

scordio commented Apr 21, 2022

Hi @hezean, thanks for the PR.

Despite my proposal at #2509 (comment), we haven't discussed these new methods in the team yet, so it may take some time before we move on to the review phase.

Thanks in advance for your patience!

@hezean
Copy link
Contributor Author

hezean commented Jan 18, 2023

Hi @scordio, it seems that 3.24.2 is already released. Any update on the methods related in this pr?

Tentatively slated for 3.24.0 solely for the purpose of team discussion
in #2520 (comment)

@scordio
Copy link
Member

scordio commented Jan 20, 2023

Hi @hezean , thanks again for your patience. I'll make sure this gets covered for 3.25.0.

@scordio scordio added this to the 3.25.0 milestone Jan 20, 2023
@scordio scordio self-assigned this Jan 20, 2023
@joel-costigliola joel-costigliola self-assigned this Feb 6, 2023
@scordio scordio removed their assignment Feb 7, 2023
Copy link
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hezean, first round of code review done. Sorry for the long wait!

Co-Authored-By: Matthew <77274680+MatthewLENG2002@users.noreply.github.com>
@hezean
Copy link
Contributor Author

hezean commented Mar 7, 2023

Hi @joel-costigliola, I really appreciate for your review, and thanks for giving me an opportunity to contribute to assertj!

I've just cleaned up this PR, fixing all the issues you pointed out. Please let me know if anything should be made better.

@joel-costigliola
Copy link
Member

Integrated thanks @hezean! I did some minor cleanup and added support for soft assertions which is a bit tricky to do if you are not familiar with how they work, you can look at the commit if you are interested, anyway you get full credit for the changes 😉

@scordio scordio mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add (Abstract)StringAssert#as(Boolean|Byte|Short|Integer|Long|Float|Double)
3 participants