Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed error reporting #11

Open
epage opened this issue Oct 27, 2017 · 3 comments
Open

More detailed error reporting #11

epage opened this issue Oct 27, 2017 · 3 comments

Comments

@epage
Copy link
Collaborator

epage commented Oct 27, 2017

I've got my own home grown tool for diffing directories but I'd much have a reusable crate.

API Ideas:

  • Enum of LeftExists, RightExists, BothExist(Option<Difference>)
  • diff_dir_list(path, path) provides an iterator of (path, enum(None))
  • diff_dir(path, path) provides an iterator of (path, enum)
    • Take advantage of difference like [assert_cli](
  • assert_dir_eq!
    • provides a default policy for failing (whether it be panic on first failure or summarize the all differences)
@steveklabnik
Copy link
Collaborator

Hey @epage ! I'm not really working on dir-diff these days, but if you want to hack on it, I'd be happy to give you commit rights, etc 👍

@epage
Copy link
Collaborator Author

epage commented Oct 27, 2017

That works.

Any vision or implementation goals you had that you'd like me to maintain with my changes?

@steveklabnik
Copy link
Collaborator

Not specifically; I had originally created this library as a way of doing testing; you could have a fixture with the directories you planned on creating, run the tests, and diff them. I'm open to whatever though. Adding you as a collaborator right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants