Remove ref project from Microsoft.AspNetCore.Testing #2817
Merged
+3
−759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious whether there are any other ramifications for this change. We'll need to test building with this change in AspNetCore. |
dougbu
reviewed
Jan 2, 2020
src/Logging/Logging.Testing/src/Microsoft.Extensions.Logging.Testing.csproj
Show resolved
Hide resolved
dougbu
approved these changes
Jan 2, 2020
JunTaoLuo
force-pushed
the
johluo/remove-testing-ref
branch
from
dc0b785 to
fda51a5
Compare
wtgodbe
approved these changes
Jan 8, 2020
|
FYI, I spoke with @wtgodbe and we already have workarounds in place so we don't need this PR for correctness. It's for cleaning up only. I won't be putting this under servicing consider, but will include it in a future patch as a tell mode infrastructure change. |
JunTaoLuo
force-pushed
the
johluo/remove-testing-ref
branch
from
fda51a5 to
27e406a
Compare
|
@JunTaoLuo Are we taking this for 3.1.2? |
|
@JunTaoLuo Aren't the "workarounds" hacks that we should cleanup outside and separate from a security update? Since we have this ready, my preference is to take this now. |
|
Yes we should be taking this in 3.1.2. It's a cleanup item. |
wtgodbe
added a commit
that referenced
this pull request
Jan 18, 2020
wtgodbe
added a commit
that referenced
this pull request
Jan 30, 2020
wtgodbe
added a commit
that referenced
this pull request
Feb 4, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
…ns#2817) \n\nCommit migrated from dotnet/extensions@b624d6b
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
wtgodbe
added a commit
that referenced
this pull request
Feb 13, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
…ns#2817) \n\nCommit migrated from dotnet/extensions@b624d6b
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit dotnet/extensions@b624d6b.\n\nCommit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 25, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…extensions#2817)" (dotnet/extensions#2882) This reverts commit b624d6ba91b9c292ff9a2aa786a575b0eaa31b4b. Commit migrated from dotnet/extensions@1286a6f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…otnet/extensions#2817)" (dotnet/extensions#2882)" (dotnet/extensions#2936) This reverts commit 1286a6ff55e300352dabeb6d778c9fcdd258bd08. Commit migrated from dotnet/extensions@7a077d4
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #2784