Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow copy_to_directory to have an empty srcs list #871

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jun 21, 2024

Requested by a Bazel support customer where a copy_to_directory target in their repo had no srcs.

Remove an explicit fail check on empty srcs since outputting an empty directory is valid in Bazel and a valid use case for copy_to_directory rule.


Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Jun 21, 2024

Test

1 test target passed

Targets
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild] 126ms

Total test execution time was 126ms. 217 tests (99.5%) were fully cached saving 44s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 423ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the allow_copy_to_directory_empty_srcs branch from e728ee6 to 0b783b0 Compare June 21, 2024 16:26
@alexeagle alexeagle merged commit 18ae5a8 into main Jun 21, 2024
36 checks passed
@alexeagle alexeagle deleted the allow_copy_to_directory_empty_srcs branch June 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants