Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coreutils download path for darwin_amd64 #853

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

mrmeku
Copy link
Contributor

@mrmeku mrmeku commented May 23, 2024


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
    Ran bazel run //:format locally to completion

Copy link

aspect-workflows bot commented May 23, 2024

Test

All tests were cache hits

215 tests (100.0%) were fully cached saving 46s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 455ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Buildifier      Format      Gazelle

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants