Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coreutils toolchain: Use statically linked linux amd64 variant #706

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: coreutils toolchain: Use statically linked linux amd64 variant #706

merged 2 commits into from
May 8, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Dec 22, 2023

Uutils has a musl release artifact for linux amd64 and linux arm64. In the future, it should probably also be possible to add a aarch64 musl toolchain. At the moment, this is not an upstream release artifact.
I'm in the process of fixing this upstream.

Type of change

Test plan

  • Covered by existing test cases

@mishazharov
Copy link

mishazharov commented Jan 12, 2024

Oh no I accidentally duplicated this in #720

I hope the maintainers take a look at one of these PRs

edit: I'll close my PR in favor of this one, because I think it's cleaner

@malt3 malt3 changed the title coreutils toolchain: Use statically linked linux amd64 variant fix: coreutils toolchain: Use statically linked linux amd64 variant May 8, 2024
malt3 added 2 commits May 8, 2024 09:12
Uutils has a musl release artifact for linux amd64.
In the future, it should probably also be possible to add a
aarch64 musl toolchain. At the moment, this is not an upstream release
artifact.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
On release 0.0.26 of uutils/coreutils, the darwin x86_64 binary is missing.
Also, any releases between 0.0.23 and 0.0.26 are missing binary artifacts.
Downgrade coreutils toolchain on darwin x86_64 for now.

https://github.com/uutils/coreutils/releases/tag/0.0.26
@malt3
Copy link
Contributor Author

malt3 commented May 8, 2024

@alexeagle @thesayyn gentle reminder. Could someone take a look at this?

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That was simple enough :)

@alexeagle alexeagle merged commit 1697a32 into bazel-contrib:main May 8, 2024
33 checks passed
@malt3 malt3 deleted the fix/uutils-musl-amd64 branch May 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: coreutils toolchain depends on glibc
4 participants