Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bzlmod (#600) #660

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

kormide
Copy link
Collaborator

@kormide kormide commented Nov 15, 2023

Cherry pick 4a4dafa into 1.x. It's needed for #659 to work.

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • Covered by existing test cases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* fix: gazelle is not a devdep

It's easy to see because we reference the symbol two lines below here

* fix: gazelle must be a regular dep

I found this mistake when trying to use bazel-lib in a downstream repo.
@kormide kormide force-pushed the cherry-pick-bzlmod-fix branch from 8d618ac to 5466d11 Compare November 15, 2023 23:26
@kormide kormide marked this pull request as ready for review November 15, 2023 23:31
@kormide kormide merged commit d2d303a into bazel-contrib:1.x Nov 15, 2023
@kormide kormide deleted the cherry-pick-bzlmod-fix branch November 15, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants