fix: swap the parameters in Ash.ToTenant.to_tenant/2 #1003
Merged
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change, but without this the protocol would never work as intended since the funtion gets dispatched based on the type of the first parameter and the resource parameter will always be an atom (precisely, an alias) so the implementation for Atom will always be called
I'll add regression tests in another PR where I call the protocol in actions, I've wanted to leave this separate to highlight the need for a breaking change
Contributor checklist