From 88c3cb79a7841f6b77180ca47fef839d72df08f0 Mon Sep 17 00:00:00 2001 From: David Capello Date: Tue, 27 Feb 2024 19:01:16 -0300 Subject: [PATCH] Changing clang-tidy-review to v0.14.0 to see if it works v0.17.1 looks buggy to download artifacts, even with this patch: https://github.com/ZedThree/clang-tidy-review/pull/115 We got the following error: File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/post.py", line 80, in main metadata, review = download_artifacts(pull_request, int(args.workflow_id)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/__init__.py", line 946, in download_artifacts contents = b"".join(data["data"].iter_content()) ~~~~^^^^^^^^ TypeError: 'NoneType' object is not subscriptable --- .github/workflows/clang_tidy.yml | 4 ++-- .github/workflows/clang_tidy_post.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 88ec62426..38114e47e 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -16,7 +16,7 @@ jobs: - uses: actions/checkout@v4 with: submodules: 'recursive' - - uses: ZedThree/clang-tidy-review@v0.17.1 + - uses: ZedThree/clang-tidy-review@v0.14.0 id: review with: build_dir: build @@ -28,5 +28,5 @@ jobs: libxcursor-dev, libxi-dev, libgl1-mesa-dev cmake_command: | cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLAF_BACKEND=none -DCMAKE_EXPORT_COMPILE_COMMANDS=on - - uses: ZedThree/clang-tidy-review/upload@v0.17.1 + - uses: ZedThree/clang-tidy-review/upload@v0.14.0 id: upload-review diff --git a/.github/workflows/clang_tidy_post.yml b/.github/workflows/clang_tidy_post.yml index 55d8fff82..4ccf7845b 100644 --- a/.github/workflows/clang_tidy_post.yml +++ b/.github/workflows/clang_tidy_post.yml @@ -13,6 +13,6 @@ jobs: post-comments: runs-on: ubuntu-latest steps: - - uses: ZedThree/clang-tidy-review/post@9a32adc734e10e4d84baa60f2b7d7c021568c527 + - uses: ZedThree/clang-tidy-review/post@v0.14.0 with: token: ${{ secrets.CLANG_TIDY_TOKEN }}