Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidocify filter failing when base_dir: :docdir #270

Closed
briandominick opened this issue May 22, 2021 · 0 comments
Closed

asciidocify filter failing when base_dir: :docdir #270

briandominick opened this issue May 22, 2021 · 0 comments
Assignees
Milestone

Comments

@briandominick
Copy link

I started getting errors from any use of asciidocify filter in a new project.

1: from /home/username/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/asciidoctor-2.0.14/lib/asciidoctor/document.rb:392:in `initialize'
/home/username/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/asciidoctor-2.0.14/lib/asciidoctor/document.rb:392:in `expand_path': asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document - no implicit conversion of Symbol into String (TypeError)

It turns out the symbol it's referring to is the :docdir in the Liquid context, which is explicitly recommended (and very handy). I don't know how this is suddenly happening. I have not used aciidocify much in the past, but I tested this on a fresh codebase with the same results.

To reproduce, set asciidoctor:base_dir to :docdir and use asciidocify anywhere.

I'm using:

  • jekyll-asciidoc 3.0.0
  • asciidoctor 2.0.14
  • jekyll 4.2.0
  • On Fedora 33
  • running Ruby 2.6.6p146

If I change docinfo to . or any explicit path, the base path and asciidocify work as expected.

@mojavelinux mojavelinux self-assigned this Nov 6, 2023
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 6, 2023
@mojavelinux mojavelinux added the bug label Nov 6, 2023
@mojavelinux mojavelinux modified the milestone: v3.0.0 Nov 6, 2023
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Nov 6, 2023
mojavelinux added a commit that referenced this issue Nov 6, 2023
@mojavelinux mojavelinux added this to the v3.0.x milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants