Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2.5.x) Update distributions dependencies #1228

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jun 24, 2023

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

  • Update distribution dependencies according to Use always latest versions in distribution聽#1227.
    asciidoctorj-diagram is excluded since v2.2.8 is not compatible with Java 8 and this branch still is.
  • Ported a tests from asciidoctorj-diagram to detect issues with it diagram and epub.

How does it achieve that?

Simply bumps the dependencies.

Are there any alternative ways to implement this?

no, that I know off 馃し

Are there any implications of this pull request? Anything a user must know?

Issue

Does not close any issue directly

Release notes

@abelsromero abelsromero marked this pull request as draft June 24, 2023 18:55
@abelsromero abelsromero force-pushed the update-distributions-dependencies branch from 50d054e to c29279d Compare June 24, 2023 19:01
* Bump asciidoctorj-pdf to 2.3.7
* Do NOT bump asciidoctorj-diagram since it's not Java8 compatible
* Add dependabot to automate updates bumps of selected dependencies
@abelsromero abelsromero marked this pull request as ready for review June 24, 2023 19:03
@robertpanzer robertpanzer merged commit 088e373 into asciidoctor:v2.5.x Jun 25, 2023
10 checks passed
@robertpanzer
Copy link
Member

Thank you!

@abelsromero abelsromero deleted the update-distributions-dependencies branch November 26, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants