Remove 'rouge' gem, already provided by AsciidoctorJ #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-87-remove-rouge-gem
branch
from
02f1401
to
714c55a
Compare
* Enable Java 8 for macos CI Fixes asciidoctor#87
|
Totally makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
[ ] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
Remove 'rouge' gem, already provided by AsciidoctorJ.
It also enables Java 8 for macos and adds CHANGELOG.
How does it achieve that?
Simply removing the dependency the gem is not packaged in the jar.
Are there any alternative ways to implement this?
No
Are there any implications of this pull request? Anything a user must know?
Not that I am aware.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #87
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc