Fix css parser #86
Merged
Fix css parser #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich is not supported by JRuby 9.3.8.0 yet.
robertpanzer
force-pushed
the
fix-css_parser
branch
from
ef62fae
to
234464a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ PDF!
Please take a bit of time giving some details about your pull request:
Kind of change
[x] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
Fix the CI build.
How does it achieve that?
The CI build is broken since a new version of css_parser, 1.13.0, was released, that requires Ruby 2.7 which is not supported by JRuby 9.3.8.0.
Since we don't have a released version of AsciidoctorJ yet that uses JRuby 9.4.0.0 this PR fixes the version of the css_parser gem to the last compatible version, 1.12.0.
Unrelated, I also upgraded gradle to the latest version, 7.6.
Are there any alternative ways to implement this?
We could release a new version of AsciidoctorJ using JRuby 9.4.0.0 which should theoretically allow to use css_parser 1.13.0.
Risks are though that this would not allow using ascidoctorj-pdf with an older version of AsciidoctorJ.
Are there any implications of this pull request? Anything a user must know?
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc