Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes fail when setting a local in maven-site v3.20.+ #968

Closed
1 of 3 tasks
abelsromero opened this issue Nov 1, 2024 · 1 comment · Fixed by #969
Closed
1 of 3 tasks

Includes fail when setting a local in maven-site v3.20.+ #968

abelsromero opened this issue Nov 1, 2024 · 1 comment · Fixed by #969
Labels
bug
Milestone
3.1.1

Comments

@abelsromero
Copy link
Member

Thank you for taking your time to talk with us!

What is this issue about?

  • Bug report 🪲
  • Feature request 🏎
  • Question ❓ Consider dropping it first in the Project Chat

Description

Includes fails when setting locale in maven-site-plugin v3.20.+.

The reason is that now files are located in src/site/{locale}/ but the locale part is not being appended when configuring the base dir

asciidoctor-maven-plugin/asciidoctor-converter-doxia-module/src/main/java/org/asciidoctor/maven/site/AsciidoctorConverterDoxiaParser.java

Line 131 in 72490d4

File siteDirectory = new File(project.getBasedir(), "src/site");
.

Environment information

  • asciidoctor-maven-plugin version: 3.1.0
  • asciidoctorj version: any
  • Maven, Java and OS version: any
@abelsromero abelsromero added the bug label Nov 1, 2024
@abelsromero abelsromero added this to the 3.1.1 milestone Nov 1, 2024
@abelsromero abelsromero changed the title Support maven-site locale Includes fail when setting a local in maven-site v3.20.+ Nov 1, 2024
@abelsromero
Copy link
Member Author

abelsromero commented Nov 1, 2024 •
edited
Loading

quick note to future self: maybe support lang also or in another release? https://docs.asciidoctor.org/asciidoctor/latest/localization-support/#customizing-labels

@abelsromero abelsromero mentioned this issue Nov 1, 2024
Merged
8 tasks
abelsromero added a commit that referenced this issue Nov 2, 2024
@abelsromero
Fix resolution of baseDir in site-integration (#969)

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
7d01bc3 
* Resolution now takes into consideration locale and siteDirectory
correctly.
* Add a warning message when multiple locales are found

Fixes #968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

(main) Fix resolution of baseDir in site-integration abelsromero/asciidoctor-maven-plugin
1 participant
@abelsromero