Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Port fixes for maven-site breadcrumbs from v2.2.x #763 #774

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Feb 11, 2024

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix for converter-doxia-module which is the continuation of the previous one.
  • Feature for the new parser-doxia-module
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Port fixes for #763 from branch v2.2.x to main (v3.0.x).

Are there any alternative ways to implement this?

I found out parser-doxia-module is going to need a new implementation different from v2.2.x 馃槥 . The later it is portable to converted-doxia-module only. I could refactor the fix into re-usable code shared in the "commons" module. To avoid users of the asciidoctor-maven-plugin pulling doxia dependencies, I added the required doxia-sink-api as provided, but I admit that's a quick-hack.
Eventually, we'd need a "commons" only for site modules.

Are there any implications of this pull request? Anything a user must know?

No

Is it related to an existing issue?

Finally, please add a corresponding entry to CHANGELOG.adoc

I am adding this as a bug fix since it was present previously

@abelsromero abelsromero changed the title Ported to converter-doxia-module (main) Ported to converter-doxia-module Feb 11, 2024
@abelsromero abelsromero marked this pull request as ready for review February 11, 2024 22:43
@abelsromero abelsromero changed the title (main) Ported to converter-doxia-module (main) Port fixes for maven-site breadcrumbs from v2.2.x Feb 11, 2024
@abelsromero abelsromero changed the title (main) Port fixes for maven-site breadcrumbs from v2.2.x (main) Port fixes for maven-site breadcrumbs from v2.2.x #763 Feb 11, 2024
@abelsromero abelsromero merged commit 1fc2014 into asciidoctor:main Feb 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant