Support description list in parser doxia module #751 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
branch-main/issue-751-support-description-list-in-parser-doxia-module
branch
from
d21b130
to
4f3c7a2
Compare
abelsromero
force-pushed
the
branch-main/issue-751-support-description-list-in-parser-doxia-module
branch
from
4f3c7a2
to
06e7f1d
Compare
* Checkpoint: tested all description lists from docs * Update docs * Update IT Closes asciidoctor#751
3 tasks
abelsromero
deleted the
branch-main/issue-751-support-description-list-in-parser-doxia-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Add support for description lists https://docs.asciidoctor.org/asciidoc/latest/lists/description/ for the new maven-parser-doxia-module.
Are there any alternative ways to implement this?
It feels like it. The fact that ordered and unordered lists tags are treated in
ListItemNodeProcessorbut for description lists I had to do the treatment on its ownNodeProcessormake me thing there's some flaw in the current approach. But so far it works and release v3 should not be delayed.Are there any implications of this pull request? Anything a user must know?
no.
Is it related to an existing issue?
Closes #751
Finally, please add a corresponding entry to CHANGELOG.adoc