(main) Test artifacts signature in CI #736
Merged
+73
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
test-artifacts-signature
branch
from
86644b6 to
32ddd03
Compare
abelsromero
force-pushed
the
test-artifacts-signature
branch
from
32ddd03 to
88142c8
Compare
Signs artifacts using same process as during a release using a test key.
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
8 tasks
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero
added a commit
that referenced
this pull request
Jan 10, 2024
Unify release configuration with PR #736 for main branch
abelsromero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Test the signature of artifacts in CI.
Are there any alternative ways to implement this?
Yes, regarding where and how to store the keys.
In the end, I decided to put them in the same code for reasons (it's a test key after all):
Are there any implications of this pull request? Anything a user must know?
no
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc