Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Test artifacts signature in CI #736

Merged
merged 1 commit into from Jan 10, 2024

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jan 10, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)
    • Remove release risks by running parts of it alongside other tests 馃
    • Experiment to eventually automate the whole release process 馃殌

What is the goal of this pull request?

Test the signature of artifacts in CI.

Are there any alternative ways to implement this?

Yes, regarding where and how to store the keys.
In the end, I decided to put them in the same code for reasons (it's a test key after all):

  1. Simpler, all resides in one place.
  2. Secrets don't work in PRs and I even had issues when setting environment variables in my fork (always empty 馃し).

Are there any implications of this pull request? Anything a user must know?

no

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

Signs artifacts using same process as during a release
using a test key.
@abelsromero abelsromero merged commit 56efcfe into asciidoctor:main Jan 10, 2024
20 checks passed
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 10, 2024
Unify release configuration with PR asciidoctor#736 for main branch
abelsromero added a commit that referenced this pull request Jan 10, 2024
Unify release configuration with PR #736 for main branch
@abelsromero abelsromero changed the title Test artifacts signature in CI (main) Test artifacts signature in CI Jan 20, 2024
@abelsromero abelsromero deleted the test-artifacts-signature branch February 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant