(v2.2.x) Fix empty destination path calculation for validation #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
changed the base branch from
main
to
update-readme-for-2.2.4-release
Newer versions of AsciidoctorJ deprecated destinationDir and only use toDir, which caused the plugin to report paths being overwritten incorrectly. Closes asciidoctor#728
abelsromero
changed the base branch from
update-readme-for-2.2.4-release
to
v2.2.x
abelsromero
changed the title
abelsromero
force-pushed
the
issue-728-fix-empty-destination-path-calculation-for-validation
branch
from
ef0a6a8
to
138add6
Compare
abelsromero
changed the title
8 tasks
abelsromero
deleted the
issue-728-fix-empty-destination-path-calculation-for-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Fix #728
Also improve message. We cannot get the exact name without duplication asciidoctor core logic, but now when outputFile is not set simply wildcard will be displayed instead of the source extension to avoid confusion:
Are there any alternative ways to implement this?
We could only check for
toDir(as done inmainbranch) but that would break builds using older AsciidoctorJ versions.Are there any implications of this pull request? Anything a user must know?
no
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc